Reserve /auth and /pluginsv2 from plugin url_prefix#66501
Merged
vincbeck merged 1 commit intoapache:mainfrom May 7, 2026
Merged
Reserve /auth and /pluginsv2 from plugin url_prefix#66501vincbeck merged 1 commit intoapache:mainfrom
vincbeck merged 1 commit intoapache:mainfrom
Conversation
potiuk
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
The framework mounts the auth-manager subapp under /auth and the FAB plugin shim under /pluginsv2, but RESERVED_URL_PREFIXES only listed /api/v2, /ui, and /execution. A trusted plugin attempting to mount under either of the missing prefixes was accepted and (because plugin init runs before the auth-manager mount) would shadow the auth routes. Plugins are trusted code per Airflow's security model so this is defense-in-depth, not a vulnerability — but accidental collisions with the auth-manager / Flask-plugins mount points should be caught and logged like the other reserved prefixes.
potiuk
force-pushed
the
f-009-reserve-auth-pluginsv2
branch
from
ff3c089 to
f054156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework mounts the auth-manager subapp under
/authand the FAB plugin shim under/pluginsv2, butRESERVED_URL_PREFIXESonly listed/api/v2,/ui, and/execution. A trusted plugin attempting to mount under either of the missing prefixes was accepted and (because plugin init runs before the auth-manager mount) would shadow the auth routes.Plugins are trusted code per Airflow's security model so this is defense-in-depth, not a vulnerability — but accidental collisions with the auth-manager / Flask-plugins mount points should be caught and logged like the other reserved prefixes.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.7 (1M context) following the guidelines