Set SameSite=Lax on SimpleAuthManager all-admins login cookie#66502
Merged
vincbeck merged 1 commit intoapache:mainfrom May 7, 2026
Merged
Set SameSite=Lax on SimpleAuthManager all-admins login cookie#66502vincbeck merged 1 commit intoapache:mainfrom
vincbeck merged 1 commit intoapache:mainfrom
Conversation
The all-admins login response set Secure (conditional on HTTPS) and HttpOnly on the JWT cookie but omitted SameSite. JWTRefreshMiddleware already sets samesite="lax" on the cookie it issues. Bring the login response in line so both code paths produce cookies with the same attributes. The cookie's Secure flag was already set conditionally based on HTTPS or configured ssl_cert — only SameSite was missing.
potiuk
force-pushed
the
f-011-samesite-login-cookie
branch
from
327d58c to
2b632f3
Compare
vincbeck
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The all-admins login response set
Secure(conditional on HTTPS) andHttpOnlyon the JWT cookie but omittedSameSite.JWTRefreshMiddlewarealready setssamesite="lax"on the cookie it issues. Bring the login response in line so both code paths produce cookies with the same attributes.The cookie's
Secureflag was already set conditionally based on HTTPS or configuredssl_cert— onlySameSitewas missing.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.7 (1M context) following the guidelines