[v3-2-test] Fix scheduler callback bundle_version when versioning disabled (#66485)#66518
Merged
Conversation
1 task
boring-cyborg
Bot
added
the
area:Scheduler
…abled (#66485) When a DAG has disable_bundle_versioning=True, dag_run.bundle_version is left None at trigger time, but DagVersion.bundle_version still records the bundle SHA captured during DAG parse. Scheduler-emitted task callbacks (zombie tasks, heartbeat timeouts, stuck-in-queued) sourced bundle_version from DagVersion, so the DFP would check out a pinned versions/<sha>/ working tree and write a _tracking lockfile for a SHA the run was never pinned to — causing the callback to run against different code than the task itself, leaving per-version checkouts on disk, and blocking stale bundle cleanup. Source bundle_version from dag_run.bundle_version so the callback inherits the same unpinned state as the run and executes against the same on-disk code the task did. (cherry picked from commit 38a51dc) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
potiuk
force-pushed
the
backport-38a51dc-v3-2-test
branch
from
7ed66f1 to
5411a5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a DAG has disable_bundle_versioning=True, dag_run.bundle_version is
left None at trigger time, but DagVersion.bundle_version still records
the bundle SHA captured during DAG parse. Scheduler-emitted task
callbacks (zombie tasks, heartbeat timeouts, stuck-in-queued) sourced
bundle_version from DagVersion, so the DFP would check out a pinned
versions// working tree and write a _tracking lockfile for a SHA
the run was never pinned to — causing the callback to run against
different code than the task itself, leaving per-version checkouts on
disk, and blocking stale bundle cleanup.
Source bundle_version from dag_run.bundle_version so the callback
inherits the same unpinned state as the run and executes against the
same on-disk code the task did.
(cherry picked from commit 38a51dc)
Co-authored-by: Ephraim Anierobi splendidzigy24@gmail.com