Skip to content

Adjust log message header for expandable sources#66570

Merged
jscheffl merged 5 commits into
apache:mainfrom
jscheffl:bugfix/adjust-log-message-header
May 9, 2026
Merged

Adjust log message header for expandable sources#66570
jscheffl merged 5 commits into
apache:mainfrom
jscheffl:bugfix/adjust-log-message-header

Conversation

@jscheffl
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl commented May 7, 2026

Inspired by PR @ashb in #66037 I am also bothered by the log source details. In our case this sometimes also contains HTTP errors of the endpoint e.g. Edge Worker not reachable to an internal Blob Storage URL which users attempt to open and then report errors. Comments already state the details might distract/confuse users but the kwargs are getting into the group and actually the log group is empty. So totally use-less.

With this PR the actual log source is hidden in the log group now, so exceptions from loading log files are not confusing users, looks like this now:

image
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@jscheffl jscheffl added this to the Airflow 3.2.2 milestone May 7, 2026
@jscheffl jscheffl added type:bug-fix Changelog: Bug Fixes area:UI Related to UI/UX. For Frontend Developers. labels May 7, 2026
@jscheffl jscheffl requested review from ashb, jason810496 and kaxil May 7, 2026 22:06
@jscheffl jscheffl force-pushed the bugfix/adjust-log-message-header branch from 798d8c7 to 4536eb7 Compare May 8, 2026 19:27
@jscheffl jscheffl force-pushed the bugfix/adjust-log-message-header branch from 4536eb7 to 6a5595e Compare May 9, 2026 15:56
@jscheffl jscheffl added full tests needed We need to run full set of tests for this PR to merge all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs labels May 9, 2026
@jscheffl jscheffl force-pushed the bugfix/adjust-log-message-header branch from 171ee68 to cecb9d9 Compare May 9, 2026 19:06
@jscheffl jscheffl merged commit 8c88254 into apache:main May 9, 2026
495 of 496 checks passed
@jscheffl jscheffl added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label May 9, 2026
@jscheffl
Copy link
Copy Markdown
Contributor Author

Added label too late, backport in #66653

jscheffl added a commit to jscheffl/airflow that referenced this pull request May 10, 2026
…66570)

* Adjust log message header for expandable sources

* Fix tests

* Fix tests

* Fix react tests

* Fix backcompat tests with old Airflow versions
(cherry picked from commit 8c88254)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request May 10, 2026
…#66653)

* [v3-2-test] Adjust log message header for expandable sources (#66570)

* Adjust log message header for expandable sources

* Fix tests

* Fix tests

* Fix react tests

* Fix backcompat tests with old Airflow versions
(cherry picked from commit 8c88254)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

* Fix UI test for log grabbing

* Fix breeze output static checks
jason810496 pushed a commit to jason810496/airflow that referenced this pull request May 11, 2026
* Adjust log message header for expandable sources

* Fix tests

* Fix tests

* Fix react tests

* Fix backcompat tests with old Airflow versions
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
…#66653)

* [v3-2-test] Adjust log message header for expandable sources (#66570)

* Adjust log message header for expandable sources

* Fix tests

* Fix tests

* Fix react tests

* Fix backcompat tests with old Airflow versions
(cherry picked from commit 8c88254)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

* Fix UI test for log grabbing

* Fix breeze output static checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs area:logging area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants