Add regression tests for cli safe flash escaping#66648
Conversation
b4583da to
6aa3049
Compare
|
@Sanskar121543 A few things need addressing before review — see our Pull Request quality criteria.
No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting |
6aa3049 to
b442c6e
Compare
Thanks! I fixed the static check issue by removing the unintended generated file change and updated the PR branch. The checks should now be clean. |
|
@Sanskar121543 A few things need addressing before review — see our Pull Request quality criteria. Issues found:
What to do next:
No rush — take your time. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
|
CI is still failing |
b442c6e to
71260b9
Compare
Thanks for checking. I pushed another fix in commit |
Summary
Adds regression coverage for
_cli_safe_flashto verify:Why
This helps prevent accidental unsafe rendering of user-controlled content in FAB auth manager flash messages.