Fix FAB role deletion foreign key constraint violation#66686
Merged
Conversation
The delete_role method used a raw DELETE on ab_role which fails with IntegrityError on databases whose FK constraints lack CASCADE (common in environments migrated from older Airflow versions). Delete association rows from ab_permission_view_role, ab_user_role, and ab_group_role before deleting the role itself.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
vincbeck
approved these changes
May 11, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When deleting a FAB role via
appbuilder.sm.delete_role(), the deletion fails with a foreign key constraint violation if the role has associated permissions or view menus. The delete operation attempts to remove the role record while the association table rows (ab_permission_view_role) still reference it.This PR adds explicit cleanup of the many-to-many associations before deleting the role record itself. The fix mirrors the pattern already used in
delete_user()within the same codebase.Fixes #65375.
Test plan
test_security_manager_delete_role_cleans_up_associationsverifies that a role with permissions can be deleted without FK constraint errorsdelete_role(), confirmed clean deletion without errorsWas generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 4.7 (1M context) following the guidelines