UI: Preserve proxied URL on login redirect#66690
Merged
Merged
Conversation
When the UI is reached through a proxy (Gitpod, Codespaces, ngrok, reverse proxies), the auth-failure interceptor sent the API server's absolute URL as the 'next' parameter, so post-login redirects went to e.g. http://localhost:29091 instead of the URL the browser is on. Send a same-origin path+search+hash instead, so the browser stays on whatever origin it is currently using. Add regression coverage for proxied subpaths so redirects also preserve base paths such as /team-a/. closes: apache#46533
desusaiteja
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
2 tasks
bbovenzi
approved these changes
May 13, 2026
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
bbovenzi
added
the
backport-to-v3-2-test
hyedall
pushed a commit
to hyedall/airflow
that referenced
this pull request
May 13, 2026
When the UI is reached through a proxy (Gitpod, Codespaces, ngrok, reverse proxies), the auth-failure interceptor sent the API server's absolute URL as the 'next' parameter, so post-login redirects went to e.g. http://localhost:29091 instead of the URL the browser is on. Send a same-origin path+search+hash instead, so the browser stays on whatever origin it is currently using. Add regression coverage for proxied subpaths so redirects also preserve base paths such as /team-a/. closes: apache#46533
1 task
vatsrahul1001
added a commit
that referenced
this pull request
May 18, 2026
When the UI is reached through a proxy (Gitpod, Codespaces, ngrok, reverse proxies), the auth-failure interceptor sent the API server's absolute URL as the 'next' parameter, so post-login redirects went to e.g. http://localhost:29091 instead of the URL the browser is on. Send a same-origin path+search+hash instead, so the browser stays on whatever origin it is currently using. Add regression coverage for proxied subpaths so redirects also preserve base paths such as /team-a/. closes: #46533 (cherry picked from commit 25ef835) Co-authored-by: Sai Teja Desu <31831475+desusaiteja@users.noreply.github.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
When the UI is reached through a proxy (Gitpod, Codespaces, ngrok, reverse proxies), the auth-failure interceptor sent the API server's absolute URL as the 'next' parameter, so post-login redirects went to e.g. http://localhost:29091 instead of the URL the browser is on. Send a same-origin path+search+hash instead, so the browser stays on whatever origin it is currently using. Add regression coverage for proxied subpaths so redirects also preserve base paths such as /team-a/. closes: #46533 (cherry picked from commit 25ef835) Co-authored-by: Sai Teja Desu <31831475+desusaiteja@users.noreply.github.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
When the UI is reached through a proxy (Gitpod, Codespaces, ngrok, reverse proxies), the auth-failure interceptor sent the API server's absolute URL as the 'next' parameter, so post-login redirects went to e.g. http://localhost:29091 instead of the URL the browser is on. Send a same-origin path+search+hash instead, so the browser stays on whatever origin it is currently using. Add regression coverage for proxied subpaths so redirects also preserve base paths such as /team-a/. closes: #46533 (cherry picked from commit 25ef835) Co-authored-by: Sai Teja Desu <31831475+desusaiteja@users.noreply.github.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 21, 2026
When the UI is reached through a proxy (Gitpod, Codespaces, ngrok, reverse proxies), the auth-failure interceptor sent the API server's absolute URL as the 'next' parameter, so post-login redirects went to e.g. http://localhost:29091 instead of the URL the browser is on. Send a same-origin path+search+hash instead, so the browser stays on whatever origin it is currently using. Add regression coverage for proxied subpaths so redirects also preserve base paths such as /team-a/. closes: #46533 (cherry picked from commit 25ef835) Co-authored-by: Sai Teja Desu <31831475+desusaiteja@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Airflow UI is reached through a proxy such as Gitpod, Codespaces, ngrok, or a reverse proxy, the auth-failure redirect can preserve the API server's absolute URL in the
nextparameter instead of the browser-visible URL. After login, that can send users to the wrong origin such ashttp://localhost:29091.This change makes the UI send a same-origin relative
nexttarget using only path, query, and hash. That keeps the browser on the current origin after login while still returning users to the same page they were on.Validation:
/team-a/...nexttarget does not include anhttp://orhttps://origin prefixcloses: #46533
Was generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5.4) following the guidelines