Skip to content

UI: Add hover feedback to Checkbox#66714

Merged
bbovenzi merged 4 commits into
apache:mainfrom
parkhojeong:fix/ui-checkbox-cursor
May 12, 2026
Merged

UI: Add hover feedback to Checkbox#66714
bbovenzi merged 4 commits into
apache:mainfrom
parkhojeong:fix/ui-checkbox-cursor

Conversation

@parkhojeong
Copy link
Copy Markdown
Contributor

@parkhojeong parkhojeong commented May 11, 2026

The enabled checkbox currently does not provide any visual feedback on hover, which feels inconsistent with expected UI behavior. Related to #66472.
image

Changes

  • Adds a cursor: pointer to Enabled Checkbox on hover.
  • keeps disabled Checkbox style(not changed).
Before After
image image
Recordings

enabled checkbox

Before After
Screen.Recording.2026-05-11.at.21.58.46.mp4
Screen.Recording.2026-05-11.at.21.59.14.mp4
Screen.Recording.2026-05-11.at.21.53.01.mp4
Screen.Recording.2026-05-11.at.21.52.12.mp4

disabled checkbox(not changed)

Before After
Screen.Recording.2026-05-11.at.22.15.45.mp4
Screen.Recording.2026-05-11.at.22.15.21.mp4

Implementation note:

For the hover effect, we should pass cursor: "pointer" to both Root and Control in Chakra UI’s ChakraCheckbox.

Since passing cursor: "pointer" directly overrides Chakra’s default styles for that element, we also need to pass the _disabled styles explicitly.

Relevant Chakra implementation details

  • @chakra-ui/react/dist/esm/theme/recipes/checkmark.js
  • @chakra-ui/react/dist/esm/styled-system/use-resolved-props.js

Chakra UI document


Was generative AI tooling used to co-author this PR?
  • Yes (codex gpt-5.5)

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 11, 2026
@parkhojeong parkhojeong force-pushed the fix/ui-checkbox-cursor branch 3 times, most recently from 1e5fd79 to bbd6642 Compare May 11, 2026 13:59
@parkhojeong parkhojeong changed the title UI: Show pointer cursor on checkbox controls UI: Show pointer cursor for Checkbox May 11, 2026
@parkhojeong parkhojeong force-pushed the fix/ui-checkbox-cursor branch from bbd6642 to afbb56a Compare May 11, 2026 14:10
@parkhojeong parkhojeong mentioned this pull request May 11, 2026
2 tasks
@parkhojeong parkhojeong marked this pull request as ready for review May 11, 2026 17:13
@parkhojeong parkhojeong changed the title UI: Show pointer cursor for Checkbox UI: Add hover feedback to Checkbox May 11, 2026
Comment thread airflow-core/src/airflow/ui/src/components/ui/Checkbox.tsx Outdated
Comment thread airflow-core/src/airflow/ui/src/components/ui/Checkbox.test.tsx Outdated
@bbovenzi bbovenzi added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label May 12, 2026
@bbovenzi bbovenzi added this to the Airflow 3.2.2 milestone May 12, 2026
@bbovenzi bbovenzi merged commit 0528893 into apache:main May 12, 2026
82 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test PR Link

bbovenzi pushed a commit that referenced this pull request May 12, 2026
* UI: Show pointer cursor for Checkbox

* UI: Remove unnecessary checkbox root cursor props

* UI: Remove checkbox tests

* UI: Inline checkbox cursor props
(cherry picked from commit 0528893)

Co-authored-by: hojeong park <parkhj062@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request May 20, 2026
* UI: Show pointer cursor for Checkbox

* UI: Remove unnecessary checkbox root cursor props

* UI: Remove checkbox tests

* UI: Inline checkbox cursor props
(cherry picked from commit 0528893)

Co-authored-by: hojeong park <parkhj062@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants