Skip to content

Pod aliases#6673

Closed
dougblack wants to merge 11 commits intoapache:masterfrom
discord:pod-aliases
Closed

Pod aliases#6673
dougblack wants to merge 11 commits intoapache:masterfrom
discord:pod-aliases

Conversation

@dougblack
Copy link

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

spennihana and others added 10 commits July 17, 2019 12:54
    Add container to serve_logs
    Fix container name
    Add containerPort
    Include env vars in serve_logs container
    Add app.kubernetes.io labels
    Create a service for worker pod log access
    add a name to the worker logs service
    Use subdomain to trigger using DNS name for FQDN
    Mount volumes in serve-logs container
    Add a --serve_logs parameter instead of a second container
    Don't include explicit True
    Set pod hostname
    Replace service if it already exists
    Add hostname to base pod spec
    Include name in replace
    Add log for testing purposes
    Patch service instead of replace
    Shorten safe pod name length
    Revert "Remove dependence on dags_volume_claim and git init"
    This reverts commit b4e5fbf.
    force k8 config to be set to 'dags_in_image'
    Terminate the DagFileProcessor after 15 seconds
    Add connect/statement timeouts for postgres
    Subclass Query with a type that can handle retries to the database
    add config to toggle between google-cloud-storage Client and GoogleCloudStorageHook
    do not wrap pre.code logs
    enable ephemeral-storage resource requests/limits
    use "limit_*" instead of "request_*" in limit request check

allow for a Resources or dict types for the resources parameter in KubernetesPodOperator
 - Update KubernetesPodOperator documentation

 https://issues.apache.org/jira/browse/AIRFLOW-5221
@XD-DENG
Copy link
Member

XD-DENG commented Nov 27, 2019

Hi @dougblack , please follow the instructions in the PR template.

On the other hand, if you would like to further test your code change, I would suggest to do that in your own fork first before you raise the PR. Repeated committing to PR would cost paid CPU time, and lengthen the build queue. So if you need more time & testing, I would suggest close this PR first.

Cheers.

@dougblack dougblack closed this Dec 2, 2019
@XD-DENG XD-DENG mentioned this pull request Dec 4, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants