[AIRFLOW-6038] AWS DataSync example_dags added#6675
[AIRFLOW-6038] AWS DataSync example_dags added#6675baolsen wants to merge 11 commits intoapache:masterfrom baolsen:datasync-example-dags
Conversation
Update with apache/airflow
Rebasing with upstream
EDIT: Managed to figure this out, it was the imports in the example_dags.Hi @potiuk Please may I ask for your assistance with this. I am not sure where to start debugging. Any advice would be appreciated. Perhaps it is how I am importing "airflow" and "airflow exceptions" in my example dags? Here is where the build is failing during "static checks": |
Codecov Report
@@ Coverage Diff @@
## master #6675 +/- ##
==========================================
- Coverage 83.86% 83.43% -0.43%
==========================================
Files 668 670 +2
Lines 37537 37590 +53
==========================================
- Hits 31479 31362 -117
- Misses 6058 6228 +170
Continue to review full report at Codecov.
|
potiuk
left a comment
There was a problem hiding this comment.
Hello @baolsen . Thanks for all the effort to make AWS operators better :). Finally we have someone who takes care of that!
However, I think that might be a good opportunity to simplify those datasync operators. I think the using complex logic in the dag (decide task) is not needed as long as we make AWS operators idempotent on their own similarly as we did with GCP operators. Pls take a look at my comments and see what you think.
There was a problem hiding this comment.
We do not need this line any more (python 3).
airflow/providers/amazon/aws/example_dags/example_datasync_complex.py
Outdated
Show resolved
Hide resolved
|
Build is passing but I'm closing this PR for now while I test against my real-world AWS account. |
|
Re-opened as |
Make sure you have checked all steps below.
Jira
Description
Added Amazon AWS how-to documentation scaffolding, plus example DAGs for AWS DataSync Operators with their respective how-to guides.
Tests
Documentation & examples.
Commits
Documentation