Skip to content

AIRFLOW-6083 - Custom Lambda client parameters#6677

Closed
Daumis102 wants to merge 4 commits intoapache:masterfrom
Daumis102:lambda_hook_custom_config
Closed

AIRFLOW-6083 - Custom Lambda client parameters#6677
Daumis102 wants to merge 4 commits intoapache:masterfrom
Daumis102:lambda_hook_custom_config

Conversation

@Daumis102
Copy link
Copy Markdown
Contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6083
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    My PR adds ability to provide Lambda client with custom configuration.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    It does not need testing as the functionality that was already implemented in function get_client_type was defaulting config param to None, which I also do in case no config is provided to AwsLambdaHook constructor. If config is provided, then the only thing I do is pass it to the client creation function, which already has everything else implemented.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Daumantas Pagojus added 4 commits November 27, 2019 12:18
…client.

There was no way to pass custom configuration from AwsLambdaHook to lambda client. This was an issue when for example default lambda timeout was too short.
@Daumis102 Daumis102 closed this Nov 27, 2019
@Daumis102 Daumis102 deleted the lambda_hook_custom_config branch November 27, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant