Avoid false TriggerDagRunOperator conflicts after ambiguous trigger retry#66911
Open
hkc-8010 wants to merge 1 commit into
Open
Avoid false TriggerDagRunOperator conflicts after ambiguous trigger retry#66911hkc-8010 wants to merge 1 commit into
hkc-8010 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid retrying the non-idempotent trigger Dag run POST through the generic execution API retry layer.
When the trigger POST raises an ambiguous transport-level
httpx.RequestError, the client now probes the requested Dag run ID. If the run exists andreset_dag_run=False, it treats the trigger as successful. If the run is missing, it re-raises the original request error.This preserves direct
409 Conflictbehavior, includingDAGRUN_ALREADY_EXISTSand the existingreset_dag_run=Trueclear path.closes: #66905
Tests:
uv run --project task-sdk ruff format task-sdk/src/airflow/sdk/api/client.py task-sdk/tests/task_sdk/api/test_client.pyuv run --project task-sdk ruff check --fix task-sdk/src/airflow/sdk/api/client.py task-sdk/tests/task_sdk/api/test_client.pyuv run --project task-sdk pytest task-sdk/tests/task_sdk/api/test_client.py::TestDagRunOperations -qprek run --files task-sdk/src/airflow/sdk/api/client.py task-sdk/tests/task_sdk/api/test_client.pybreeze testing task-sdk-tests --python 3.10 task-sdk/tests/task_sdk/api/test_client.py::TestDagRunOperationsbreeze testing task-sdk-tests --python 3.10breeze ci selective-check --commit-ref HEAD --default-branch main --github-repository apache/airflowWas generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.