Skip to content

Avoid false TriggerDagRunOperator conflicts after ambiguous trigger retry#66911

Open
hkc-8010 wants to merge 1 commit into
apache:mainfrom
hkc-8010:fix/trigger-dagrun-ambiguous-retry
Open

Avoid false TriggerDagRunOperator conflicts after ambiguous trigger retry#66911
hkc-8010 wants to merge 1 commit into
apache:mainfrom
hkc-8010:fix/trigger-dagrun-ambiguous-retry

Conversation

@hkc-8010
Copy link
Copy Markdown
Contributor

Avoid retrying the non-idempotent trigger Dag run POST through the generic execution API retry layer.

When the trigger POST raises an ambiguous transport-level httpx.RequestError, the client now probes the requested Dag run ID. If the run exists and reset_dag_run=False, it treats the trigger as successful. If the run is missing, it re-raises the original request error.

This preserves direct 409 Conflict behavior, including DAGRUN_ALREADY_EXISTS and the existing reset_dag_run=True clear path.

closes: #66905

Tests:

  • uv run --project task-sdk ruff format task-sdk/src/airflow/sdk/api/client.py task-sdk/tests/task_sdk/api/test_client.py
  • uv run --project task-sdk ruff check --fix task-sdk/src/airflow/sdk/api/client.py task-sdk/tests/task_sdk/api/test_client.py
  • uv run --project task-sdk pytest task-sdk/tests/task_sdk/api/test_client.py::TestDagRunOperations -q
  • prek run --files task-sdk/src/airflow/sdk/api/client.py task-sdk/tests/task_sdk/api/test_client.py
  • breeze testing task-sdk-tests --python 3.10 task-sdk/tests/task_sdk/api/test_client.py::TestDagRunOperations
  • breeze testing task-sdk-tests --python 3.10
  • breeze ci selective-check --commit-ref HEAD --default-branch main --github-repository apache/airflow

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: OpenAI Codex following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TriggerDagRunOperator can fail with DagRunAlreadyExists after ambiguous execution API trigger retry

1 participant