[AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible#6692
Merged
potiuk merged 2 commits intoDec 18, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6692 +/- ##
==========================================
- Coverage 83.84% 83.52% -0.32%
==========================================
Files 668 668
Lines 37567 37569 +2
==========================================
- Hits 31498 31381 -117
- Misses 6069 6188 +119
Continue to review full report at Codecov.
|
potiuk
requested changes
Nov 30, 2019
Member
potiuk
left a comment
There was a problem hiding this comment.
- First of all - there are few places where key of the Dict is limited to str.
- Secondly I think there is a big value in using Any, even if it can be skipped. First of all you signal to the developer that comes after you that you deliberately accept Any type passed (and it's not an overlook). Also you can use Optional[Any] and detect the cases where None values can cause problems.
2ff2a2d to
3dd8774
Compare
3dd8774 to
ccdd390
Compare
potiuk
approved these changes
Dec 18, 2019
KKcorps
pushed a commit
to KKcorps/airflow
that referenced
this pull request
Dec 21, 2019
…he#6692) * [AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
…he#6692) * [AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation