Skip to content

[AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible#6692

Merged
potiuk merged 2 commits into
apache:masterfrom
PolideaInternal:AIRFLOW-6130-pylint-cassandra-to-gcs
Dec 18, 2019
Merged

[AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible#6692
potiuk merged 2 commits into
apache:masterfrom
PolideaInternal:AIRFLOW-6130-pylint-cassandra-to-gcs

Conversation

@turbaszek
Copy link
Copy Markdown
Member

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 30, 2019

Codecov Report

Merging #6692 into master will decrease coverage by 0.31%.
The diff coverage is 44.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6692      +/-   ##
==========================================
- Coverage   83.84%   83.52%   -0.32%     
==========================================
  Files         668      668              
  Lines       37567    37569       +2     
==========================================
- Hits        31498    31381     -117     
- Misses       6069     6188     +119
Impacted Files Coverage Δ
airflow/operators/cassandra_to_gcs.py 64.91% <44.92%> (+1.59%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.2% <0%> (-20.52%) ⬇️
airflow/configuration.py 89.13% <0%> (-3.63%) ⬇️
airflow/utils/dag_processing.py 57.99% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e2c09d...ccdd390. Read the comment docs.

Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • First of all - there are few places where key of the Dict is limited to str.
  • Secondly I think there is a big value in using Any, even if it can be skipped. First of all you signal to the developer that comes after you that you deliberately accept Any type passed (and it's not an overlook). Also you can use Optional[Any] and detect the cases where None values can cause problems.

Comment thread airflow/operators/cassandra_to_gcs.py Outdated
Comment thread airflow/operators/cassandra_to_gcs.py Outdated
Comment thread airflow/operators/cassandra_to_gcs.py Outdated
Comment thread airflow/operators/cassandra_to_gcs.py Outdated
Comment thread airflow/operators/cassandra_to_gcs.py Outdated
Comment thread airflow/operators/cassandra_to_gcs.py Outdated
Comment thread airflow/operators/cassandra_to_gcs.py Outdated
Comment thread airflow/operators/cassandra_to_gcs.py Outdated
Comment thread airflow/operators/cassandra_to_gcs.py Outdated
Comment thread airflow/operators/cassandra_to_gcs.py Outdated
@turbaszek turbaszek force-pushed the AIRFLOW-6130-pylint-cassandra-to-gcs branch from 2ff2a2d to 3dd8774 Compare November 30, 2019 14:47
@turbaszek turbaszek requested a review from potiuk December 1, 2019 10:22
@turbaszek turbaszek force-pushed the AIRFLOW-6130-pylint-cassandra-to-gcs branch from 3dd8774 to ccdd390 Compare December 2, 2019 13:40
@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Dec 3, 2019
@potiuk potiuk merged commit 0fdde86 into apache:master Dec 18, 2019
KKcorps pushed a commit to KKcorps/airflow that referenced this pull request Dec 21, 2019
…he#6692)

* [AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
…he#6692)

* [AIRFLOW-6130] Make Cassandra to GCS operator pylint compatible
@turbaszek turbaszek deleted the AIRFLOW-6130-pylint-cassandra-to-gcs branch March 14, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants