Skip to content

[AIRFLOW-6133] Make Hive transfer operators pylint compatible#6695

Merged
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:pylint-hive-transfer
Dec 1, 2019
Merged

[AIRFLOW-6133] Make Hive transfer operators pylint compatible#6695
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:pylint-hive-transfer

Conversation

@turbaszek
Copy link
Member

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits.

.format(k, v)
for k, v in self.hive_tblproperties.items()])
hql = """\
hql = f"""\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@codecov-io
Copy link

codecov-io commented Dec 1, 2019

Codecov Report

Merging #6695 into master will decrease coverage by 0.3%.
The diff coverage is 70.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6695      +/-   ##
==========================================
- Coverage   83.83%   83.52%   -0.31%     
==========================================
  Files         668      668              
  Lines       37547    37565      +18     
==========================================
- Hits        31477    31377     -100     
- Misses       6070     6188     +118
Impacted Files Coverage Δ
airflow/contrib/operators/vertica_to_hive.py 0% <0%> (ø) ⬆️
airflow/operators/mysql_to_hive.py 100% <100%> (ø) ⬆️
airflow/operators/hive_to_mysql.py 100% <100%> (ø) ⬆️
airflow/contrib/operators/hive_to_dynamodb.py 100% <100%> (ø) ⬆️
airflow/operators/mssql_to_hive.py 100% <100%> (ø) ⬆️
airflow/operators/hive_to_samba_operator.py 100% <100%> (ø) ⬆️
airflow/operators/hive_to_druid.py 65.15% <28.57%> (+0.53%) ⬆️
airflow/operators/s3_to_hive_operator.py 94.01% <71.42%> (+0.05%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815c96e...3360ed4. Read the comment docs.

@turbaszek turbaszek marked this pull request as ready for review December 1, 2019 16:06
@potiuk potiuk merged commit e036827 into apache:master Dec 1, 2019
@turbaszek turbaszek deleted the pylint-hive-transfer branch December 4, 2019 11:19
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
…#6695)

* [AIRFLOW-6133] Make Hive transfer operators pylint compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants