Fix ASYNC110 violation in edge3 worker#66955
Open
sanwar47 wants to merge 1 commit into
Open
Conversation
The polling loop that waits for the supervisor process to exit used:
while job.is_running:
await sleep(0.1)
This trips ruff ASYNC110 (await inside a while-condition loop).
Refactor to the ASYNC110-clean pattern used elsewhere:
while True:
if not job.is_running:
break
await sleep(0.1)
Same behaviour, passes static-checks CI.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Contributor
|
The code has just been replaced by PR #65943 - nevertheless functionally the PR does not change but just models it in a way that RUFF does not complaint. It is not improving the polling busy loop at all. So a check violation exclusion would be preferred in my view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The polling loop introduced in #66144 to wait for the supervisor process
to fully exit after grabbing results from the queue used the pattern
while job.is_running: await sleep(0.1).This trips ruff's ASYNC110 rule (flake8-async: avoid await inside a
while-condition loop) and was causing the static-checks CI job to fail
on every open PR.
Fix: refactor to the equivalent while True / if not break form, which
is ASYNC110-clean and has identical runtime behaviour.