fix: preserve XCom multi-column sorting#66964
Open
auyua9 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for the pr Could you share a recording of the expected behavior and the current behavior? I tested your code with Shift-click, but multiple column sorting still doesn't seem to work. Screen.Recording.2026-05-15.at.17.27.07.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve multi-column XCom sorting across the table URL state and API request.
Summary:
sortsearch params when serializing table stateorderBylisttask_display_nametotask_idmapping for each sort entryTests:
./node_modules/.bin/vitest run src/components/DataTable/searchParams.test.ts src/pages/XCom/orderBy.test.ts./node_modules/.bin/eslint --quiet src/components/DataTable/searchParams.test.ts src/components/DataTable/searchParams.ts src/pages/XCom/XCom.tsx src/pages/XCom/orderBy.test.ts src/pages/XCom/orderBy.ts./node_modules/.bin/tsc -p tsconfig.app.json --noEmitgit diff --checkWas generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex, following the guidelines.