Skip to content

fix: preserve XCom multi-column sorting#66964

Open
auyua9 wants to merge 1 commit into
apache:mainfrom
auyua9:fix/xcom-multi-sort-auyua9
Open

fix: preserve XCom multi-column sorting#66964
auyua9 wants to merge 1 commit into
apache:mainfrom
auyua9:fix/xcom-multi-sort-auyua9

Conversation

@auyua9
Copy link
Copy Markdown

@auyua9 auyua9 commented May 14, 2026

Preserve multi-column XCom sorting across the table URL state and API request.

Summary:

  • keep repeated sort search params when serializing table state
  • map every XCom sorting entry into the API orderBy list
  • keep the existing task_display_name to task_id mapping for each sort entry

Tests:

  • ./node_modules/.bin/vitest run src/components/DataTable/searchParams.test.ts src/pages/XCom/orderBy.test.ts
  • ./node_modules/.bin/eslint --quiet src/components/DataTable/searchParams.test.ts src/components/DataTable/searchParams.ts src/pages/XCom/XCom.tsx src/pages/XCom/orderBy.test.ts src/pages/XCom/orderBy.ts
  • ./node_modules/.bin/tsc -p tsconfig.app.json --noEmit
  • git diff --check

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: OpenAI Codex, following the guidelines.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 14, 2026
@parkhojeong
Copy link
Copy Markdown
Contributor

parkhojeong commented May 15, 2026

Thanks for the pr

Could you share a recording of the expected behavior and the current behavior?

I tested your code with Shift-click, but multiple column sorting still doesn't seem to work.

Screen.Recording.2026-05-15.at.17.27.07.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants