Preserve Databricks deferrable trigger caller across triggerer restarts#66965
Open
Nishieee wants to merge 1 commit into
Open
Preserve Databricks deferrable trigger caller across triggerer restarts#66965Nishieee wants to merge 1 commit into
Nishieee wants to merge 1 commit into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Contributor
SameerMesiah97
left a comment
SameerMesiah97
left a comment
There was a problem hiding this comment.
Just a few nits. Looks fine otherwise.
| TASK_RUN_ID3 = 33 | ||
| TASK_RUN_ID3_KEY = "third_task" | ||
| JOB_ID = 42 | ||
| RUN_PAGE_URL = "https://XX.cloud.databricks.com/#jobs/1/runs/1" |
Contributor
There was a problem hiding this comment.
I would add a constant called CALLER here and then use that in your tests.. I think it's okay to use the same caller argument for both as the string itself is not behaviorally important
| :param retry_limit: The number of times to retry the connection in case of service outages. | ||
| :param retry_delay: The number of seconds to wait between retries. | ||
| :param retry_args: An optional dictionary with arguments passed to ``tenacity.Retrying`` class. | ||
| :param run_page_url: The run page url. |
Contributor
There was a problem hiding this comment.
Should we not add docstring entries for repair_run and caller?
| By default, the trigger will poll every 30 seconds. | ||
| :param retry_limit: The number of times to retry the connection in case of service outages. | ||
| :param retry_delay: The number of seconds to wait between retries. | ||
| :param retry_args: An optional dictionary with arguments passed to ``tenacity.Retrying`` class. |
Contributor
There was a problem hiding this comment.
Same here. I think we should add a docstring entry for caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DatabricksExecutionTriggerandDatabricksSQLStatementExecutionTriggerpassedcallerintoDatabricksHookbut omitted it fromserialize(), so the triggerer lost the operator’s value after restart/handoff. Persistcalleron the instance, include it inserialize(), and add tests for default serialization and round-trip.related: #66961
Was generative AI tooling used to co-author this PR?
Generated-by: Cursor following the guidelines