Enable ruff PLE1205 to catch logging calls with too many arguments#66978
Merged
shahar1 merged 3 commits intoMay 15, 2026
Merged
Conversation
boring-cyborg
Bot
added
area:logging
area:providers
provider:amazon
shahar1
commented
May 15, 2026
shahar1
requested review from
Lee-W,
eladkal,
jason810496,
jscheffl,
potiuk and
vatsrahul1001
Lee-W
approved these changes
May 15, 2026
Extra positional arguments to logging methods are silently dropped when
the format string has no corresponding placeholder. Enable PLE1205
(logging-too-many-args) and fix all 12 existing instances:
- Add missing %s placeholders where the value was being discarded
- Merge accidentally split message strings (ssm.py)
- Replace {}-style placeholders with %s (four system test files)
…e.py Co-authored-by: Wei Lee <weilee.rx@gmail.com>
shahar1
force-pushed
the
enable-ruff-PLE1205-logging-too-many-args
branch
from
be1a9c3 to
4fa39e5
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
loggingcall has more positional arguments than the format string has%-placeholders, the extra arguments are silently dropped and the intended information never appears in the log. EnablePLE1205(logging-too-many-args) to make this a lint error, and fix all 12 existing instances.Changes
PLE1205toextend-select.%splaceholder for the caughtOSErrorinfile_task_handler.py.redshift_data.py: collapse two-string call into"Invalid poll_interval: %s", poll_intervalssm.py: merge accidentally split message strings into one format string with%stask_log_fetcher.py(×2): add%sfor the captured exceptioncompute.py(×2): add%ssoself.bodyis actually loggeddrive.py: add%sfor theGoogleApiClientError{}placeholders (logging uses%s, not.format()syntax)Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 4.6) following the guidelines