Skip to content

[AIRFLOW-6136] Remove hardcoded project ID in example_dag#6698

Merged
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:AIRFLOW-6136
Dec 1, 2019
Merged

[AIRFLOW-6136] Remove hardcoded project ID in example_dag#6698
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:AIRFLOW-6136

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Nov 30, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-6136
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Nov 30, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 30, 2019

Codecov Report

Merging #6698 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6698      +/-   ##
==========================================
- Coverage   83.83%   83.51%   -0.32%     
==========================================
  Files         668      668              
  Lines       37555    37555              
==========================================
- Hits        31483    31363     -120     
- Misses       6072     6192     +120
Impacted Files Coverage Δ
airflow/gcp/example_dags/example_mlengine.py 84.48% <ø> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.2% <0%> (-20.52%) ⬇️
airflow/configuration.py 89.13% <0%> (-3.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a867db7...fd88755. Read the comment docs.

@mik-laj mik-laj requested a review from potiuk November 30, 2019 23:38
@potiuk potiuk merged commit fb144ae into apache:master Dec 1, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants