[v3-2-test] Mark Dags stale when their bundle is removed from config (#66948)#66985
Merged
Conversation
…66948) * Mark Dags stale when their bundle is removed from config When a Dag bundle is removed from the bundle config, sync_bundles_to_db flipped the bundle's active flag to False but left its Dags with is_stale=False. The processor stops parsing files for inactive bundles, so the time-based check in deactivate_stale_dags never fired for them. deactivate_stale_dags now reads the set of active bundles from the DagBundleModel table and treats any non-stale Dag whose bundle is not active as stale, in addition to the existing last_parsed_time check for Dags in active bundles. If the bundle reappears in config later, the existing parse path resets is_stale to False per Dag. * Apply suggestions from code review Co-authored-by: Wei Lee <weilee.rx@gmail.com> --------- (cherry picked from commit 01be07a) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com>
vatsrahul1001
approved these changes
May 18, 2026
vatsrahul1001
requested review from
ephraimbuddy and
jedcunningham
as code owners
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
…66948) (#66985) * Mark Dags stale when their bundle is removed from config When a Dag bundle is removed from the bundle config, sync_bundles_to_db flipped the bundle's active flag to False but left its Dags with is_stale=False. The processor stops parsing files for inactive bundles, so the time-based check in deactivate_stale_dags never fired for them. deactivate_stale_dags now reads the set of active bundles from the DagBundleModel table and treats any non-stale Dag whose bundle is not active as stale, in addition to the existing last_parsed_time check for Dags in active bundles. If the bundle reappears in config later, the existing parse path resets is_stale to False per Dag. * Apply suggestions from code review --------- (cherry picked from commit 01be07a) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
…66948) (#66985) * Mark Dags stale when their bundle is removed from config When a Dag bundle is removed from the bundle config, sync_bundles_to_db flipped the bundle's active flag to False but left its Dags with is_stale=False. The processor stops parsing files for inactive bundles, so the time-based check in deactivate_stale_dags never fired for them. deactivate_stale_dags now reads the set of active bundles from the DagBundleModel table and treats any non-stale Dag whose bundle is not active as stale, in addition to the existing last_parsed_time check for Dags in active bundles. If the bundle reappears in config later, the existing parse path resets is_stale to False per Dag. * Apply suggestions from code review --------- (cherry picked from commit 01be07a) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 21, 2026
…66948) (#66985) * Mark Dags stale when their bundle is removed from config When a Dag bundle is removed from the bundle config, sync_bundles_to_db flipped the bundle's active flag to False but left its Dags with is_stale=False. The processor stops parsing files for inactive bundles, so the time-based check in deactivate_stale_dags never fired for them. deactivate_stale_dags now reads the set of active bundles from the DagBundleModel table and treats any non-stale Dag whose bundle is not active as stale, in addition to the existing last_parsed_time check for Dags in active bundles. If the bundle reappears in config later, the existing parse path resets is_stale to False per Dag. * Apply suggestions from code review --------- (cherry picked from commit 01be07a) Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> Co-authored-by: Wei Lee <weilee.rx@gmail.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Dag bundle is removed from the bundle config, sync_bundles_to_db
flipped the bundle's active flag to False but left its Dags with
is_stale=False. The processor stops parsing files for inactive bundles,
so the time-based check in deactivate_stale_dags never fired for them.
deactivate_stale_dags now reads the set of active bundles from the
DagBundleModel table and treats any non-stale Dag whose bundle is not
active as stale, in addition to the existing last_parsed_time check for
Dags in active bundles. If the bundle reappears in config later, the
existing parse path resets is_stale to False per Dag.
Co-authored-by: Wei Lee weilee.rx@gmail.com
(cherry picked from commit 01be07a)
Co-authored-by: Ephraim Anierobi splendidzigy24@gmail.com
Co-authored-by: Wei Lee weilee.rx@gmail.com