Avoid row locks for queued executor events#67043
Open
dsherniiazov wants to merge 2 commits into
Open
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
735cd73 to
f60111e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #66794
Queued executor events only need to persist
external_executor_id, so they should not go through the scheduler path that locks task instance rows withFOR UPDATE SKIP LOCKED.This change processes
QUEUEDexecutor events with a directUPDATE, while keepingRUNNING,SUCCESS,FAILED, andRESTARTINGevents on the existing locked path.Added regression coverage for:
external_executor_idwithout row locksTests:
uv run --package apache-airflow-core ruff check airflow-core/src/airflow/jobs/scheduler_job_runner.py airflow-core/tests/unit/jobs/test_scheduler_job.pyuv run --package apache-airflow-core ruff format --check airflow-core/src/airflow/jobs/scheduler_job_runner.py airflow-core/tests/unit/jobs/test_scheduler_job.pyuv run --package apache-airflow-core pytest airflow-core/tests/unit/jobs/test_scheduler_job.py -q -k "process_executor_events_queued_updates_without_row_lock or process_executor_events_mixed_queued_and_failed_locks_only_failed or test_process_executor_events or test_process_executor_events_with_no_callback or test_process_executor_events_ti_requeued or test_process_executor_events_multiple_try_numbers_warns"