Fix variables import with structured falsy values#67060
Open
Leondon9 wants to merge 2 commits into
Open
Conversation
Prab-27
reviewed
May 17, 2026
| @@ -0,0 +1 @@ | |||
| Fix variable import handling for structured falsy values. | |||
Contributor
There was a problem hiding this comment.
Do we need this ? I believe - It's related any major changes
WDYT ?
Contributor
There was a problem hiding this comment.
We are generating this while releasing. Indeed it doesn't need for any PR. Seems we are missing comment on top of document
Contributor
There was a problem hiding this comment.
Happy to see it has already implemented ! @bugraoz93 , Do we also need to add a prek hook for it ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix variable import handling for structured falsy values.
This keeps core CLI and
airflowctlimport semantics aligned when a variable entry is shaped like{"value": ..., "description": ...}and the value is falsy, such as an empty string,0,false, ornull.It also makes
airflowctl variables importreject non-object JSON input with the existing invalid-file error instead of failing later while iterating.Tests:
breeze run pytest airflow-ctl/tests/airflow_ctl/ctl/commands/test_variable_command.py -xvsbreeze run pytest airflow-core/tests/unit/cli/commands/test_variable_command.py::TestCliVariables::test_variables_import_with_structured_falsy_values -xvsprek run ruff --files airflow-core/src/airflow/cli/commands/variable_command.py airflow-core/tests/unit/cli/commands/test_variable_command.py airflow-ctl/src/airflowctl/ctl/commands/variable_command.py airflow-ctl/tests/airflow_ctl/ctl/commands/test_variable_command.pyWas generative AI tooling used to co-author this PR?
Generated-by: Codex (GPT-5) following the guidelines