[v3-2-test] Tighten deserialization allowlist regex to require full-string match (#66499)#67096
Merged
Merged
Conversation
…tring match (#66499) * Tighten deserialization allowlist regex to use full-string match The ``allowed_deserialization_classes_regexp`` allowlist used ``re.match()``, which only anchors at the start of the string. A pattern like ``airflow\.models\.Variable`` therefore also admitted classnames such as ``airflow.models.Variable_Malicious``. Switch to ``re.fullmatch()`` so the admin's pattern matches the entire classname; document the semantics in the config description so operators know to use ``.*`` for prefix-style allowances. * Add newsfragment for #66499 --------- (cherry picked from commit 80f1ab4) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
1 task
amoghrajesh
approved these changes
May 18, 2026
jason810496
approved these changes
May 18, 2026
vatsrahul1001
added
the
type:misc/internal
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
…tring match (#66499) (#67096) * Tighten deserialization allowlist regex to use full-string match The ``allowed_deserialization_classes_regexp`` allowlist used ``re.match()``, which only anchors at the start of the string. A pattern like ``airflow\.models\.Variable`` therefore also admitted classnames such as ``airflow.models.Variable_Malicious``. Switch to ``re.fullmatch()`` so the admin's pattern matches the entire classname; document the semantics in the config description so operators know to use ``.*`` for prefix-style allowances. * Add newsfragment for #66499 --------- (cherry picked from commit 80f1ab4) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 20, 2026
…tring match (#66499) (#67096) * Tighten deserialization allowlist regex to use full-string match The ``allowed_deserialization_classes_regexp`` allowlist used ``re.match()``, which only anchors at the start of the string. A pattern like ``airflow\.models\.Variable`` therefore also admitted classnames such as ``airflow.models.Variable_Malicious``. Switch to ``re.fullmatch()`` so the admin's pattern matches the entire classname; document the semantics in the config description so operators know to use ``.*`` for prefix-style allowances. * Add newsfragment for #66499 --------- (cherry picked from commit 80f1ab4) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
vatsrahul1001
added a commit
that referenced
this pull request
May 21, 2026
…tring match (#66499) (#67096) * Tighten deserialization allowlist regex to use full-string match The ``allowed_deserialization_classes_regexp`` allowlist used ``re.match()``, which only anchors at the start of the string. A pattern like ``airflow\.models\.Variable`` therefore also admitted classnames such as ``airflow.models.Variable_Malicious``. Switch to ``re.fullmatch()`` so the admin's pattern matches the entire classname; document the semantics in the config description so operators know to use ``.*`` for prefix-style allowances. * Add newsfragment for #66499 --------- (cherry picked from commit 80f1ab4) Co-authored-by: Jarek Potiuk <jarek@potiuk.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
allowed_deserialization_classes_regexpallowlist usedre.match(),which only anchors at the start of the string. A pattern like
airflow\.models\.Variabletherefore also admitted classnames such asairflow.models.Variable_Malicious. Switch tore.fullmatch()so theadmin's pattern matches the entire classname; document the semantics in
the config description so operators know to use
.*for prefix-styleallowances.
(cherry picked from commit 80f1ab4)
Co-authored-by: Jarek Potiuk jarek@potiuk.com
Co-authored-by: Rahul Vats 43964496+vatsrahul1001@users.noreply.github.com