Fix ValueError when supervisor force-closes stuck sockets after timeout#67115
Merged
vatsrahul1001 merged 2 commits intoMay 19, 2026
Merged
Conversation
7a58932 to
9465ed7
Compare
vatsrahul1001
approved these changes
May 19, 2026
amoghrajesh
approved these changes
May 19, 2026
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
Non blocking nit, otherwise LGTM
Member
|
Interesting. I sort of hoped that the stuck socket timeout never fired. |
Contributor
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Some Edge workers intermittently fail with the following error:
After analyzing the issue, we found that after the socket cleanup timeout fires and _cleanup_open_sockets() closes the selector, the monitor loop was not exited. On the next iteration it called selector.select() on the already-closed epoll object, causing the ValueError.
Details of change: