Skip to content

Add prek hook to enforce keyword-only session on @provide_session #67150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jason810496 wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add prek hook to enforce keyword-only session on @provide_session #67150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9767b07
Add prek hook to check that no new @provide_session functions declare…
jason810496 May 18, 2026
b960a2f
Address Copilot review feedback on provide_session prek hook
jason810496 May 19, 2026
6ee5679
Normalize paths when detecting allowlist-edit bypass
jason810496 May 19, 2026
05f4b75
Clarify --generate log line to name the scanned source roots
jason810496 May 19, 2026
ac9fdfe
Harden allowlist handling against deletion and unsafe entries
jason810496 May 19, 2026
4070be0
Handle invalid UTF-8 in provide_session hook
jason810496 May 19, 2026
7c6e452
Remove unused provide_session test fixture attribute
jason810496 May 19, 2026
3190db6
Close allowlist-removal bypass in provide_session prek hook
jason810496 May 19, 2026
19f2e2a
CI: Fix scripts/ci/prek/known_provide_session_positional.txt
jason810496 May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,6 +1064,12 @@ repos:
language: python
pass_filenames: true
files: ^(airflow-core|airflow-ctl|task-sdk|providers|shared)/.*\.py$
- id: check-no-new-provide-session-positional
name: Check that no new @provide_session functions declare `session` positionally
entry: ./scripts/ci/prek/check_provide_session_kwargs.py
language: python
pass_filenames: true
files: ^(airflow-core|airflow-ctl|task-sdk|providers|shared)/.*\.py$|^scripts/ci/prek/known_provide_session_positional\.txt$|^scripts/ci/prek/check_provide_session_kwargs\.py$
Copy link
Copy Markdown
Member

@Lee-W Lee-W May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we're not suppose to have provide_session in task-sdk

Copy link
Copy Markdown
Member

@Lee-W Lee-W May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like so.

Copy link
Copy Markdown
Member Author

@jason810496 jason810496 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

- id: check-no-new-airflow-core-utils-modules
name: Check that no new modules are added under airflow-core/src/airflow/utils
entry: ./scripts/ci/prek/check_no_new_airflow_core_utils_modules.py
Expand Down
Loading
Loading