Fix error messages in PythonVirtualenvOperator when Azure Key Vault secret backend is configured#67157
Merged
Conversation
…ecret backend is configured
jscheffl
reviewed
May 19, 2026
jscheffl
reviewed
May 19, 2026
…voperator-with-azure-key-vault-secret-backend
jscheffl
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Azure Key Vault secrets backend raises an
HttpResponseError(BadParameter) when Airflow requests a variable whose key contains a dot. Azure Key Vault secret names only allow alphanumeric characters and dashes ([a-zA-Z0-9-]), so dots in the variable key cause the API call to fail.This affects:
my.app.settingwill fail when looked up through this backend.PythonVirtualenvOperatorspecifically — it callsVariable.get("PythonVirtualenvOperator.cache_key", "")on every execution to compute its virtualenv cache hash. This means every DAG usingPythonVirtualenvOperatorproduces an ERROR on every run when the Azure Key Vault backend is configured, even though the variable not existing is perfectly fine (it defaults to"").The resulting error floods the logs:
Fix
Rename the
PythonVirtualenvOperatorcache variable fromPythonVirtualenvOperator.cache_keytopython_virtualenv_operator_cache_key. This avoids the dot that is incompatible with secrets backends that restrict allowed characters (like Azure Key Vault). The underscore-only name is properly normalized by the existingbuild_pathlogic.Add a validation guard in the Azure Key Vault backend —
_get_secret_valuenow validates the constructed secret name against Azure Key Vault's naming rules (1-127 chars, alphanumeric and dashes only) before making the API call. Invalid names returnNonewith a WARNING log, alerting the user that their variable cannot be resolved via Key Vault. This replaces the previous behavior of letting Azure throw an unhandledHttpResponseErrorat ERROR level.Migration note
The cache hash computation for
PythonVirtualenvOperatornow reads frompython_virtualenv_operator_cache_keyinstead ofPythonVirtualenvOperator.cache_key. Since most users never set this variable (it's an optional manual cache-busting override), the only effect is a one-time rebuild of cached virtual environments due to the changed hash input.Was generative AI tooling used to co-author this PR?
GitHub Copilot - Claude Opus 4.6
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.