Skip to content

[AIRFLOW-6158] Upgrade sendgrid dependency#6719

Merged
potiuk merged 1 commit intoapache:masterfrom
ms32035:AIRFLOW-6158
Dec 9, 2019
Merged

[AIRFLOW-6158] Upgrade sendgrid dependency#6719
potiuk merged 1 commit intoapache:masterfrom
ms32035:AIRFLOW-6158

Conversation

@ms32035
Copy link
Contributor

@ms32035 ms32035 commented Dec 3, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Update Airflow code to support Sendgrid client 6.0 / Sendgrid API v3

Tests

  • Existing tests modified

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link

Codecov Report

Merging #6719 into master will decrease coverage by 0.31%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6719      +/-   ##
==========================================
- Coverage   83.83%   83.52%   -0.32%     
==========================================
  Files         668      668              
  Lines       37569    37565       -4     
==========================================
- Hits        31497    31376     -121     
- Misses       6072     6189     +117
Impacted Files Coverage Δ
airflow/contrib/utils/sendgrid.py 87.03% <66.66%> (-0.9%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.2% <0%> (-20.52%) ⬇️
airflow/configuration.py 89.13% <0%> (-3.63%) ⬇️
airflow/utils/dag_processing.py 58.48% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fed459...ed553b7. Read the comment docs.

@potiuk potiuk merged commit 6f5c8cf into apache:master Dec 9, 2019
@ms32035 ms32035 deleted the AIRFLOW-6158 branch December 9, 2019 10:09
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants