Skip to content

Replace per-TI session.merge() with a single UPDATE keyed on TI.id when a dagrun_timeout fires #67198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ColtenOuO wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −4
Open

Replace per-TI session.merge() with a single UPDATE keyed on TI.id when a dagrun_timeout fires #67198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions airflow-core/src/airflow/jobs/scheduler_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2403,10 +2403,14 @@ def _schedule_dag_run(
key=lambda ti: ti.start_date or timezone.make_aware(datetime.min),
default=None,
)
for task_instance in unfinished_task_instances:
task_instance.state = TaskInstanceState.SKIPPED
session.merge(task_instance)
session.flush()
if unfinished_task_instances:
session.execute(
update(TI)
.where(TI.id.in_(ti.id for ti in unfinished_task_instances))
.values(state=TaskInstanceState.SKIPPED)
.execution_options(synchronize_session="fetch")
)
session.flush()
self.log.info("Run %s of %s has timed-out", dag_run.run_id, dag_run.dag_id)

if dag_run.state in State.finished_dr_states and dag_run.run_type in (
Expand Down
Loading