[AIRFLOW-6165] Housekeep utils.dates.date_range & add tests#6720
Merged
kaxil merged 1 commit intoapache:masterfrom Dec 4, 2019
Merged
[AIRFLOW-6165] Housekeep utils.dates.date_range & add tests#6720kaxil merged 1 commit intoapache:masterfrom
kaxil merged 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6720 +/- ##
==========================================
- Coverage 83.84% 83.54% -0.31%
==========================================
Files 669 669
Lines 37692 37694 +2
==========================================
- Hits 31603 31491 -112
- Misses 6089 6203 +114
Continue to review full report at Codecov.
|
kaxil
approved these changes
Dec 4, 2019
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
utils.dates.date_rangehas a few issues, like missing docstring, doesn't handle wrong-type input properly, and always try to runtimezone.make_naiveonstart_dateeven if it's already naive (which will cause exception).This PR addresses these issues, and add tests for
utils.dates.date_range.Tests
Commits
Documentation