AGENTS.md: require translating domain-layer exceptions to HTTPException at FastAPI route boundaries#67221
Merged
choo121600 merged 1 commit intoMay 20, 2026
Conversation
…ion` at FastAPI route boundaries
amoghrajesh
approved these changes
May 20, 2026
choo121600
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Core API route handlers that let domain-layer
ValueErrors (e.g., fromMetastoreStateBackend) bubble up surface as500 Internal Server Error, leaking internals and misleading clients. Capture the rule so future agents catch and re-raise asHTTPExceptionwith the right status.What
## Coding Standardsin rootAGENTS.mddirecting agents to catch domain-layer exceptions incore_apiroute handlers and re-raise asHTTPException(404not-found,400invalid input).Was generative AI tooling used to co-author this PR?