Refactor Elasticsearch log formatter to use timezone.from_timestamp#67245
Open
23tae wants to merge 3 commits into
Open
Refactor Elasticsearch log formatter to use timezone.from_timestamp#6724523tae wants to merge 3 commits into
23tae wants to merge 3 commits into
Conversation
a236358 to
21350e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
ElasticsearchJSONFormatterto use the standard Airflowtimezone.from_timestamputility, addressing a TODO in the codebase.This is a companion PR to #66856, which applies the same refactoring pattern to the Elasticsearch provider.
Key changes
from_timestampinairflow.sdk.timezoneto make it part of the public Task SDK API (shared changes with Refactor Opensearch log formatter to use timezone.from_timestamp and export it in Task SDK #66856).timezone.from_timestampon Airflow 3.3.0+ and maintains backward compatibility by falling back to the originalpendulum/datetimelogic on older Airflow 3.x releases.Verification Results
I have verified the changes using both
prek(ruff) andbreeze(standardized Docker environment).Was generative AI tooling used to co-author this PR?
Generated-by: Antigravity following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.