Skip to content

Fix CloudComposerExternalTaskSensor success on empty execution window#67257

Open
wtfashwin wants to merge 2 commits into
apache:mainfrom
wtfashwin:fix/composer-external-task-sensor-empty-window
Open

Fix CloudComposerExternalTaskSensor success on empty execution window#67257
wtfashwin wants to merge 2 commits into
apache:mainfrom
wtfashwin:fix/composer-external-task-sensor-empty-window

Conversation

@wtfashwin
Copy link
Copy Markdown

CloudComposerExternalTaskSensor and CloudComposerExternalTaskTrigger reported success whenever no in-window task instance was in a disallowed state. When every returned task instance fell outside the requested execution_range, the helper still returned success instead of continuing to wait for a relevant in-window task instance.

_check_task_instances_states now only returns success when at least one task instance is inside the requested window and all in-window task instances satisfy the expected state set, mirroring the equivalent CloudComposerDAGRunSensor fix.

closes: #67051


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

CloudComposerExternalTaskSensor and CloudComposerExternalTaskTrigger
reported success whenever no in-window task instance was in a
disallowed state. When every returned task instance fell outside the
requested execution_range, the helper still returned success instead of
continuing to wait for a relevant in-window task instance.

_check_task_instances_states now only returns success when at least one
task instance is inside the requested window and all in-window task
instances satisfy the expected state set, mirroring the equivalent
CloudComposerDAGRunSensor fix.

closes: apache#67051
@wtfashwin wtfashwin requested a review from shahar1 as a code owner May 20, 2026 18:32
@boring-cyborg boring-cyborg Bot added area:providers provider:google Google (including GCP) related issues labels May 20, 2026
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented May 20, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@MaksYermak
Copy link
Copy Markdown
Contributor

As I see this PR is duplication for this one #67052

Screenshot 2026-05-22 at 17 54 18

@shahar1 what should we do in this case?

@shahar1
Copy link
Copy Markdown
Contributor

shahar1 commented May 22, 2026

As I see this PR is duplication for this one #67052

Screenshot 2026-05-22 at 17 54 18 @shahar1 what should we do in this case?

Current approach is to allow raising multiple PRs for resolving an issue, and the first PR that becomes suitable for merging will be merged while the others will be closed.
However, I do have some expectations when reviewing such "competitive" PRs:

  1. The authors are aware of other existing ongoing attempts, especially if they were reviewed, and address their issues (in this case, running the system tests against a real Cloud Composer instance).
  2. AI usage should be declared.

I won't review this PR until the above conditions are met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CloudComposerExternalTaskSensor succeeds when all task instances are outside execution_range

3 participants