Fix CloudComposerExternalTaskSensor success on empty execution window#67257
Open
wtfashwin wants to merge 2 commits into
Open
Fix CloudComposerExternalTaskSensor success on empty execution window#67257wtfashwin wants to merge 2 commits into
wtfashwin wants to merge 2 commits into
Conversation
CloudComposerExternalTaskSensor and CloudComposerExternalTaskTrigger reported success whenever no in-window task instance was in a disallowed state. When every returned task instance fell outside the requested execution_range, the helper still returned success instead of continuing to wait for a relevant in-window task instance. _check_task_instances_states now only returns success when at least one task instance is inside the requested window and all in-window task instances satisfy the expected state set, mirroring the equivalent CloudComposerDAGRunSensor fix. closes: apache#67051
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Contributor
Contributor
Current approach is to allow raising multiple PRs for resolving an issue, and the first PR that becomes suitable for merging will be merged while the others will be closed.
I won't review this PR until the above conditions are met. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


CloudComposerExternalTaskSensor and CloudComposerExternalTaskTrigger reported success whenever no in-window task instance was in a disallowed state. When every returned task instance fell outside the requested execution_range, the helper still returned success instead of continuing to wait for a relevant in-window task instance.
_check_task_instances_states now only returns success when at least one task instance is inside the requested window and all in-window task instances satisfy the expected state set, mirroring the equivalent CloudComposerDAGRunSensor fix.
closes: #67051
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.