Recover SKIPPED state when supervisor IPC fails on terminal-state send#67266
Open
haseebmalik18 wants to merge 1 commit into
Open
Recover SKIPPED state when supervisor IPC fails on terminal-state send#67266haseebmalik18 wants to merge 1 commit into
haseebmalik18 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a task is going to be SKIPPED and the IPC send of
TaskState(SKIPPED)to the supervisor raises, the failure gets logged and swallowed. The subprocess exits 0, the supervisor sees no terminal state, andfinal_statedefaults to SUCCESS. SUCCESS is inSTATES_SENT_DIRECTLYso nofinish()call is made either, and the TI sits at RUNNING on the server until something else cleans it up.Fix is a small pre-announcement: before sending the real
TaskState(SKIPPED), the subprocess sendsSetIntendedTerminalState(SKIPPED). Supervisor stores it on_last_intended_state, andfinal_stateuses it as a fallback when the bigger message never lands. Same shape as theSERVER_TERMINATEDoverride that alreadyexists alongside it.
Nothing changes on the worker side. No
sys.exit(1),finalize()still runs,on_skipped_callbackand the skipped listener hook fire as usual.