Skip to content

Fix execute_async method key parameter type hint in AwsBatchExecutor #67269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Prab-27 wants to merge 1 commit into from
Closed

Fix execute_async method key parameter type hint in AwsBatchExecutor #67269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions providers/amazon/src/airflow/providers/amazon/aws/executors/batch/batch_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
AllBatchConfigKeys,
BatchJob,
BatchJobCollection,
BatchJobWorkloadKey,
BatchQueuedJob,
)
from airflow.utils.state import State
Expand Down Expand Up @@ -402,9 +403,7 @@ def _describe_jobs(self, job_ids) -> list[BatchJob]:
all_jobs.extend(describe_workloads_response["jobs"])
return all_jobs

def execute_async(
self, key: TaskInstanceKey | str, command: CommandType, queue=None, executor_config=None
):
def execute_async(self, key: BatchJobWorkloadKey, command: CommandType, queue=None, executor_config=None):
"""Save the workload to be executed in the next sync using Boto3's RunTask API."""
if executor_config and "command" in executor_config:
raise ValueError('Executor Config should never override "command"')
Expand Down
7 changes: 6 additions & 1 deletion providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,12 @@ def test_invalid_executor_config(self, mock_get_kube_client, mock_kubernetes_job
try:
assert executor.event_buffer == {}
executor.execute_async(
key=("dag", "task", timezone.utcnow(), 1),
key=TaskInstanceKey(
dag_id="dag",
task_id="task",
run_id="run",
try_number=1,
),
queue=None,
command=["airflow", "tasks", "run", "true", "some_parameter"],
executor_config=k8s.V1Pod(
Expand Down
Loading