Fix missing task instance history for failed tasks outside of RUNNING state#67371
Open
kalluripradeep wants to merge 2 commits into
Open
Fix missing task instance history for failed tasks outside of RUNNING state#67371kalluripradeep wants to merge 2 commits into
kalluripradeep wants to merge 2 commits into
Conversation
… state Closes apache#67238 Closes apache#65366 When a task fails from states like QUEUED or DEFERRED, or is failed by the executor or trigger, its state is not RUNNING. The history recording in fetch_handle_failure_context incorrectly assumed that only RUNNING tasks needed their history recorded, which led to missing tries in task_instance_history when CeleryExecutor or KubernetesExecutor failed tasks or triggers failed them. Now, we record history for all states except RESTARTING (since RESTARTING tasks were already cleared and had their history recorded).
kalluripradeep
force-pushed
the
fix-missing-ti-history-celery
branch
from
3dc516e to
67fa256
Compare
potiuk
added
the
ready for maintainer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of the changes.
closes: #67238
closes: #65366
When a task fails from states like QUEUED or DEFERRED, or is failed by the executor or trigger, its state is not RUNNING. The history recording in
fetch_handle_failure_contextincorrectly assumed that only RUNNING tasks needed their history recorded, which led to missing tries intask_instance_historywhenCeleryExecutororKubernetesExecutorfailed tasks or triggers failed them. Now, we record history for all states exceptRESTARTING(sinceRESTARTINGtasks were already cleared and had their history recorded).