Fix BigQueryStreamingBufferEmptySensor false negative metadata lag#67401
Open
arsenelupin14 wants to merge 4 commits into
Open
Fix BigQueryStreamingBufferEmptySensor false negative metadata lag#67401arsenelupin14 wants to merge 4 commits into
arsenelupin14 wants to merge 4 commits into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Member
|
@arsenelupin14 A few things need addressing before review — see our Pull Request quality criteria.
No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting |
40c800a to
17c9bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66963
BigQuery's streamingBuffer metadata is eventually consistent, causing false negatives in BigQueryStreamingBufferEmptySensor immediately after a streaming insert.
This PR introduces a consecutive_empty_checks parameter (by default: 1) to the sensor and its deferrable trigger. By setting this to >1, the sensor will require multiple consecutive empty observations before passing, safely bypassing the lag window. Also removes the manual time.sleep workaround from example_bigquery_streaming_buffer_sensor.py .