Skip to content

Fix calendar failed run colors#67402

Closed
bobu-putheeckal wants to merge 1 commit into
apache:mainfrom
bobu-putheeckal:codex-airflow-66959-calendar-failed-color
Closed

Fix calendar failed run colors#67402
bobu-putheeckal wants to merge 1 commit into
apache:mainfrom
bobu-putheeckal:codex-airflow-66959-calendar-failed-color

Conversation

@bobu-putheeckal
Copy link
Copy Markdown

Fixes #66959.

What changed

  • Render failed-only Calendar buckets with the failed/red color in Total Runs mode instead of the success/green palette.
  • Render buckets containing both successful/running and failed runs as split green/red cells.
  • Add focused Calendar scale tests for failed-only and mixed actual Total Runs buckets.

Tests

  • npx --yes pnpm@10.25.0 test src/pages/Dag/Calendar/calendarUtils.test.ts
  • npx --yes pnpm@10.25.0 exec tsc --p tsconfig.app.json --noEmit
  • npx --yes pnpm@10.25.0 exec eslint src/pages/Dag/Calendar/calendarUtils.ts src/pages/Dag/Calendar/calendarUtils.test.ts

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 24, 2026
@choo121600
Copy link
Copy Markdown
Member

For your other UI-related PRs as well, it would be helpful if you could include before/after screenshots in the PR description.

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label May 24, 2026
@bobu-putheeckal
Copy link
Copy Markdown
Author

Added more detail here for the visual change: the affected Calendar Total Runs buckets now render failed-only days with the failed/red palette, and mixed success+failed days with split green/red cells instead of solid success green. I do not have a reliable local backend-rendered Calendar fixture for a true before/after screenshot in this environment, so I kept the verification focused on the color-selection regression tests in calendarUtils.test.ts.

@kaxil
Copy link
Copy Markdown
Member

kaxil commented May 24, 2026

PR template hasn't been followed on any of your PRs. As such I am closing all your PRs since I see little to no evidence of actual testing and mass PRs to Airflow & other repos.

@kaxil kaxil closed this May 24, 2026
@kaxil kaxil added the ai-slop label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-slop area:UI Related to UI/UX. For Frontend Developers. ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI: Calendar view renders failed runs in solid green, indistinguishable from success

4 participants