Improve DAG toggle contrast in dark mode#67406
Closed
bobu-putheeckal wants to merge 1 commit into
Closed
Conversation
Author
|
Additional detail: the visual change is isolated to the shared Chakra switch recipe in dark mode. Unchecked DAG toggles now get a token-based border ( |
Member
|
PR template hasn't been followed on any of your PRs. As such I am closing all your PRs since I see little to no evidence of actual testing and mass PRs to Airflow & other repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improve dark-mode switch contrast by adding a dark-mode border to the shared Chakra switch control. The checked state keeps using the existing color palette token, while the unchecked/off state gains a visible outline on dark surfaces.
This addresses the DAG pause toggle contrast reported in #66759.
Why
In dark mode, the unchecked switch track can blend into the surrounding dark background, making paused/off DAG toggles hard to distinguish. A token-based border makes the switch shape clearer without introducing new colors or changing light-mode behavior.
Tests
pnpm exec eslint src/theme.tspnpm exec tsc --p tsconfig.app.json --pretty falsepnpm buildScreenshots
I could not capture a full Airflow DAG-list screenshot from the raw Vite dev shell because that shell depends on Airflow backend-provided base/config values to render the app. The change is limited to the theme recipe and was verified with the focused static checks and production build above.
closes: #66759
Was generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex following the guidelines