Improve airflowctl required field validation#67410
Conversation
|
@bobu-putheeckal A few things need addressing before review — see our Pull Request quality criteria.
No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting |
|
Pushed |
|
PR template hasn't been followed on any of your PRs. As such I am closing all your PRs since I see little to no evidence of actual testing and mass PRs to Airflow & other repos. |
Improve airflowctl client-side validation for API request bodies so missing required generated Pydantic fields are reported clearly before building/sending requests.
Changes:
is_required().Closes: #57721
Tests:
uv run --project airflow-ctl ruff check airflow-ctl/src/airflowctl/api/operations.py airflow-ctl/src/airflowctl/ctl/cli_config.py airflow-ctl/src/airflowctl/ctl/commands/connection_command.py airflow-ctl/src/airflowctl/ctl/commands/pool_command.py airflow-ctl/src/airflowctl/ctl/commands/variable_command.py airflow-ctl/src/airflowctl/exceptions.py airflow-ctl/tests/airflow_ctl/api/test_operations.py airflow-ctl/tests/airflow_ctl/ctl/commands/test_connections_command.py airflow-ctl/tests/airflow_ctl/ctl/commands/test_pool_command.py airflow-ctl/tests/airflow_ctl/ctl/commands/test_variable_command.pyuv run --project airflow-ctl pytest airflow-ctl/testsWas generative AI tooling used to co-author this PR?
Generated-by: OpenAI Codex