Skip to content

Fix backfill API session handling for SQLite#67411

Closed
bobu-putheeckal wants to merge 1 commit into
apache:mainfrom
bobu-putheeckal:codex-airflow-66726-sqlite-backfill
Closed

Fix backfill API session handling for SQLite#67411
bobu-putheeckal wants to merge 1 commit into
apache:mainfrom
bobu-putheeckal:codex-airflow-66726-sqlite-backfill

Conversation

@bobu-putheeckal
Copy link
Copy Markdown

Summary

  • pass the request-scoped API session into _create_backfill when creating backfills
  • keep existing CLI/model behavior by letting _create_backfill create its own session when one is not supplied
  • add a regression test that fails if the API path opens a separate backfill model session

Fixes #66726

Testing

  • uv run --no-dev --package apache-airflow-core --with 'apache-airflow-devel-common[basic]' ruff check airflow-core/src/airflow/models/backfill.py airflow-core/src/airflow/api_fastapi/core_api/routes/public/backfills.py airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_backfills.py
  • PYTHONPATH="airflow-core/src:airflow-core/tests:devel-common/src:providers/git/src:providers/standard/src:providers/fab/src:shared/configuration/src:shared/dagnode/src:shared/listeners/src:shared/logging/src:shared/module_loading/src:shared/observability/src:shared/plugins_manager/src:shared/providers_discovery/src:shared/secrets_backend/src:shared/secrets_masker/src:shared/serialization/src:shared/state/src:shared/template_rendering/src:shared/timezones/src" uv run --python 3.12 --no-dev --package apache-airflow-core --with-editable ./devel-common --with 'apache-airflow-devel-common[basic]' --with-editable ./providers/git --with-editable ./providers/standard --with-editable ./providers/fab python -m pytest airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_backfills.py::TestCreateBackfill -q

Was generative AI tooling used to co-author this PR?
  • Yes — OpenAI Codex

Generated-by: OpenAI Codex following the guidelines in contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions

@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label May 24, 2026
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label May 24, 2026
@kaxil
Copy link
Copy Markdown
Member

kaxil commented May 24, 2026

PR template hasn't been followed on any of your PRs. As such I am closing all your PRs since I see little to no evidence of actual testing and mass PRs to Airflow & other repos.

@kaxil kaxil closed this May 24, 2026
@kaxil kaxil added the ai-slop label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-slop area:API Airflow's REST/HTTP API ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a backfill via Airflow API results in internal server error if SQLite is used

3 participants