Skip to content

Run custom connection form validators#67416

Closed
bobu-putheeckal wants to merge 1 commit into
apache:mainfrom
bobu-putheeckal:codex-airflow-64835-connection-custom-validation
Closed

Run custom connection form validators#67416
bobu-putheeckal wants to merge 1 commit into
apache:mainfrom
bobu-putheeckal:codex-airflow-64835-connection-custom-validation

Conversation

@bobu-putheeckal
Copy link
Copy Markdown

What

Run legacy provider connection form validators for submitted extra fields when connections are created or updated through the API-backed UI form. This restores custom get_connection_form_widgets() validator callbacks returning validation errors instead of saving invalid values.

Fixes #64835

Tests

  • PYTHONPATH="airflow-core/src:devel-common/src:shared/configuration/src:shared/dagnode/src:shared/listeners/src:shared/logging/src:shared/module_loading/src:shared/observability/src:shared/plugins_manager/src:shared/providers_discovery/src:shared/secrets_backend/src:shared/secrets_masker/src:shared/serialization/src:shared/state/src:shared/template_rendering/src:shared/timezones/src:task-sdk/src" uv run --project airflow-core --no-sync pytest airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_connections.py -k "form_widget_validator"
  • PYTHONPATH="airflow-core/src:devel-common/src:shared/configuration/src:shared/dagnode/src:shared/listeners/src:shared/logging/src:shared/module_loading/src:shared/observability/src:shared/plugins_manager/src:shared/providers_discovery/src:shared/secrets_backend/src:shared/secrets_masker/src:shared/serialization/src:shared/state/src:shared/template_rendering/src:shared/timezones/src:task-sdk/src" uv run --project airflow-core --no-sync ruff check airflow-core/src/airflow/api_fastapi/core_api/services/public/connections.py airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_connections.py
  • PYTHONPATH="airflow-core/src:devel-common/src:shared/configuration/src:shared/dagnode/src:shared/listeners/src:shared/logging/src:shared/module_loading/src:shared/observability/src:shared/plugins_manager/src:shared/providers_discovery/src:shared/secrets_backend/src:shared/secrets_masker/src:shared/serialization/src:shared/state/src:shared/template_rendering/src:shared/timezones/src:task-sdk/src" uv run --project airflow-core --no-sync ruff format --check airflow-core/src/airflow/api_fastapi/core_api/services/public/connections.py airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_connections.py

Notes

No frontend files were changed, so frontend tests, eslint, and tsc were not run. A broader initial uv run pytest ... from the workspace root was blocked by jpype1 requiring a Java runtime for the all-extras JDBC dependency on this machine.

@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label May 24, 2026
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label May 24, 2026
@kaxil
Copy link
Copy Markdown
Member

kaxil commented May 24, 2026

PR template hasn't been followed on any of your PRs. As such I am closing all your PRs since I see little to no evidence of actual testing and mass PRs to Airflow & other repos.

@kaxil kaxil closed this May 24, 2026
@kaxil kaxil added the ai-slop label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-slop area:API Airflow's REST/HTTP API ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom validations are not called in connection forms

3 participants