Run custom connection form validators#67416
Closed
bobu-putheeckal wants to merge 1 commit into
Closed
Conversation
Member
|
PR template hasn't been followed on any of your PRs. As such I am closing all your PRs since I see little to no evidence of actual testing and mass PRs to Airflow & other repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Run legacy provider connection form validators for submitted extra fields when connections are created or updated through the API-backed UI form. This restores custom
get_connection_form_widgets()validator callbacks returning validation errors instead of saving invalid values.Fixes #64835
Tests
PYTHONPATH="airflow-core/src:devel-common/src:shared/configuration/src:shared/dagnode/src:shared/listeners/src:shared/logging/src:shared/module_loading/src:shared/observability/src:shared/plugins_manager/src:shared/providers_discovery/src:shared/secrets_backend/src:shared/secrets_masker/src:shared/serialization/src:shared/state/src:shared/template_rendering/src:shared/timezones/src:task-sdk/src" uv run --project airflow-core --no-sync pytest airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_connections.py -k "form_widget_validator"PYTHONPATH="airflow-core/src:devel-common/src:shared/configuration/src:shared/dagnode/src:shared/listeners/src:shared/logging/src:shared/module_loading/src:shared/observability/src:shared/plugins_manager/src:shared/providers_discovery/src:shared/secrets_backend/src:shared/secrets_masker/src:shared/serialization/src:shared/state/src:shared/template_rendering/src:shared/timezones/src:task-sdk/src" uv run --project airflow-core --no-sync ruff check airflow-core/src/airflow/api_fastapi/core_api/services/public/connections.py airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_connections.pyPYTHONPATH="airflow-core/src:devel-common/src:shared/configuration/src:shared/dagnode/src:shared/listeners/src:shared/logging/src:shared/module_loading/src:shared/observability/src:shared/plugins_manager/src:shared/providers_discovery/src:shared/secrets_backend/src:shared/secrets_masker/src:shared/serialization/src:shared/state/src:shared/template_rendering/src:shared/timezones/src:task-sdk/src" uv run --project airflow-core --no-sync ruff format --check airflow-core/src/airflow/api_fastapi/core_api/services/public/connections.py airflow-core/src/airflow/api_fastapi/core_api/routes/public/connections.py airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_connections.pyNotes
No frontend files were changed, so frontend tests, eslint, and tsc were not run. A broader initial
uv run pytest ...from the workspace root was blocked byjpype1requiring a Java runtime for the all-extras JDBC dependency on this machine.