Fix Celery worker service account in RBAC bindings#67436
Closed
bobu-putheeckal wants to merge 1 commit into
Closed
Fix Celery worker service account in RBAC bindings#67436bobu-putheeckal wants to merge 1 commit into
bobu-putheeckal wants to merge 1 commit into
Conversation
Member
|
PR template hasn't been followed on any of your PRs. As such I am closing all your PRs since I see little to no evidence of actual testing and mass PRs to Airflow & other repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67261.
What changed
This updates Celery worker RBAC subjects to resolve the worker service account name using
workers.celery.serviceAccountwith the same fallback behavior as the Celery worker templates.The pod-launcher, job-launcher, and SCC role bindings now reference the custom Celery worker service account when users set
workers.celery.serviceAccount.name. For hybrid Celery/Kubernetes executor deployments, the templates also keep the fallback Kubernetes worker service account subject when it differs from the Celery worker service account and no dedicatedworkers.kubernetes.serviceAccountis configured.Tests
uv run pytest tests/helm_tests/airflow_aux/test_pod_launcher_role.py tests/helm_tests/airflow_aux/test_job_launcher_role.py tests/helm_tests/security/test_scc_rolebinding.pyhelm lint charthelm template test chart --show-only templates/rbac/pod-launcher-rolebinding.yaml --set allowPodLaunching=true --set executor=CeleryExecutor --set workers.celery.serviceAccount.name=workerhelm template test chart --show-only templates/rbac/job-launcher-rolebinding.yaml --set allowJobLaunching=true --set executor=CeleryExecutor --set workers.celery.serviceAccount.name=worker