Skip to content

Propagate verify and botocore_config in AWS Batch triggers#67508

Merged
kaxil merged 1 commit into
apache:mainfrom
KarshVashi:fix/batch-triggers-propagate-base-aws-params
May 25, 2026
Merged

Propagate verify and botocore_config in AWS Batch triggers#67508
kaxil merged 1 commit into
apache:mainfrom
KarshVashi:fix/batch-triggers-propagate-base-aws-params

Conversation

@KarshVashi
Copy link
Copy Markdown
Contributor

Batch triggers (BatchJobTrigger, BatchCreateComputeEnvironmentTrigger) did not forward
verify or botocore_config to the hook, so deferrable Batch operators silently dropped
custom SSL and botocore settings when polling AWS from the triggerer.

Follows the same pattern established in the Lambda trigger migration
(providers/amazon/src/airflow/providers/amazon/aws/triggers/lambda_function.py).

What this changes:

  • Adds **kwargs passthrough in both trigger __init__ methods so base-class params
    (verify, botocore_config) reach AwsBaseWaiterTrigger
  • Updates both hook() methods to pass self.verify and self.botocore_config to
    BatchClientHook
  • Updates operator defer sites to forward verify and botocore_config to the triggers
  • Converts BatchCreateComputeEnvironmentTrigger call from positional to keyword args
  • Adds test coverage for serialization and hook propagation of both triggers

Part of #35278


Was generative AI tooling used to co-author this PR?
  • Yes - Claude Code (Opus 4.6)

@KarshVashi KarshVashi requested a review from o-nikolas as a code owner May 25, 2026 22:33
@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels May 25, 2026
@kaxil kaxil merged commit 0a2f181 into apache:main May 25, 2026
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants