Skip to content

Fix example_mwaa_serverless system test race condition with stop_workflow_run#67578

Merged
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:onikolas/mwaa_serverless_wait
May 27, 2026
Merged

Fix example_mwaa_serverless system test race condition with stop_workflow_run#67578
vincbeck merged 1 commit into
apache:mainfrom
aws-mwaa:onikolas/mwaa_serverless_wait

Conversation

@o-nikolas
Copy link
Copy Markdown
Contributor

The stop_workflow_run task was failing with a ValidationException because the workflow run completed before the stop command could be issued. This was particularly problematic on high-latency executors (e.g., ECS) where task launch overhead (~90s) gave the workflow enough time to finish.

The fix introduces a second workflow definition (stoppable_workflow.yaml) that sensors for a non-existent S3 key, keeping the workflow running indefinitely until explicitly stopped.

Ran the system test locally and it passed


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

…flow_run

The stop_workflow_run task was failing with a ValidationException because
the workflow run completed before the stop command could be issued. This
was particularly problematic on high-latency executors (e.g., ECS) where
task launch overhead (~90s) gave the workflow enough time to finish.

The fix introduces a second workflow definition (stoppable_workflow.yaml)
that sensors for a non-existent S3 key, keeping the workflow running
indefinitely until explicitly stopped.
@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels May 26, 2026
@o-nikolas o-nikolas requested review from ferruzzi and vincbeck May 26, 2026 22:05
@vincbeck vincbeck merged commit 4eab62d into apache:main May 27, 2026
94 checks passed
@vincbeck vincbeck deleted the onikolas/mwaa_serverless_wait branch May 27, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants