Skip to content

Make session parameter in dag_clear CLI keyword only#67582

Merged
jason810496 merged 1 commit into
apache:mainfrom
jason810496:fix/cli-dag-clear-session-parameter-positional
May 27, 2026
Merged

Make session parameter in dag_clear CLI keyword only#67582
jason810496 merged 1 commit into
apache:mainfrom
jason810496:fix/cli-dag-clear-session-parameter-positional

Conversation

@jason810496
Copy link
Copy Markdown
Member

What

Check that no new @provide_session functions declare `session` positionally...............................Failed
- hook id: check-no-new-provide-session-positional
- exit code: 1

  ╭────────────────────────────────────── Check failed ──────────────────────────────────────╮
  │ New @provide_session function with positional ``session`` detected.                      │
  │ Move ``session`` after a bare ``*`` in the signature so callers must pass it by keyword: │
  │                                                                                          │
  │   @provide_session                                                                       │
  │   def foo(arg, *, session: Session = NEW_SESSION) -> None: ...                           │
  │                                                                                          │
  │ If this usage is intentional and pre-existing, run:                                      │
  │                                                                                          │
  │   uv run ./scripts/ci/prek/check_provide_session_kwargs.py --generate                    │
  │                                                                                          │
  │ to regenerate the allowlist, then commit the updated                                     │
  │ scripts/ci/prek/known_provide_session_positional.txt.                                    │
  ╰──────────────────────────────────────────────────────────────────────────────────────────╯
    airflow-core/src/airflow/cli/commands/dag_command.py  count=9 (allowed=8)
        L128 def dag_clear(...)
        L365 def dag_state(...)
        L476 def dag_list_dags(...)
        L564 def dag_details(...)
        L586 def dag_list_import_errors(...)
        L675 def dag_list_jobs(...)
        L706 def dag_list_dag_runs(...)
        L744 def dag_test(...)
        L802 def dag_reserialize(...)

@Prab-27
Copy link
Copy Markdown
Contributor

Prab-27 commented May 27, 2026

Let's wait for CI

@jason810496 jason810496 merged commit cd431ee into apache:main May 27, 2026
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants