fix: migrate deprecated imports to SDK equivalents (airflow-ai)#67623
Closed
yugmerabtene wants to merge 2 commits into
Closed
fix: migrate deprecated imports to SDK equivalents (airflow-ai)#67623yugmerabtene wants to merge 2 commits into
yugmerabtene wants to merge 2 commits into
Conversation
yugmerabtene
requested review from
Lee-W,
RNHTTR,
amoghrajesh,
ashb,
bugraoz93,
dheerajturaga,
dstandish,
gopidesupavan,
hussein-awala,
jedcunningham,
josh-fell,
jscheffl,
kaxil,
mobuchowski,
o-nikolas,
potiuk,
shahar1,
uranusjr and
vincbeck
as code owners
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
yugmerabtene
requested review from
XD-DENG,
bolkedebruin,
choo121600,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
boring-cyborg
Bot
added
provider:common-ai
provider:databricks
provider:dbt-cloud
provider:docker
provider:edge
Applied 312 import path corrections across 275 files: - airflow.utils.state -> airflow.sdk.state - airflow.utils.helpers -> airflow.sdk.utils.helpers - airflow.utils.log -> airflow.sdk.utils.log - airflow.exceptions.AirflowException -> airflow.sdk.exceptions.AirflowException - airflow.utils.timezone -> pendulum Generated by airflow-fix (github.com/yugmerabtene/airflow-fix)
| ) | ||
| from airflow.providers.common.compat.sdk import AirflowException | ||
| from airflow.utils.timezone import datetime | ||
| import pendulum # replaces airflow.utils.timezone datetime |
Contributor
There was a problem hiding this comment.
Wouldn't that break lines 377 and 378?
Wouldn't it be necessary to update them to
pendulum.datetime(...)or use the time zone present in the SDK?
| from airflow.utils.state import State | ||
| from airflow.utils.timezone import datetime | ||
| from airflow.sdk.state import State | ||
| import pendulum # replaces airflow.utils.timezone datetime |
Contributor
There was a problem hiding this comment.
Same here, I believe this would imply all lines that are using datetime.
The original fix replaced 'from airflow.utils.timezone import datetime'
with 'import pendulum', but this broke existing datetime(...) calls
since they would now resolve to the stdlib datetime class instead of
pendulum's timezone-aware datetime function.
The correct fix is 'from pendulum import datetime', which preserves
all existing datetime(...) call sites.
Also fixed utcnow() -> pendulum.now('UTC'),
convert_to_utc() -> pendulum.instance(x).in_timezone('UTC'),
coerce_datetime -> pendulum.instance
where applicable.
Author
|
Good catch @Pedrinhonitz — broke existing call sites since they resolved to stdlib datetime instead of pendulum's timezone-aware version. Fixed across all 36 affected files:
Updated in commit 6e61409 on the same branch. |
kaxil
reviewed
May 28, 2026
| from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook | ||
| from airflow.providers.amazon.aws.operators.base_aws import AwsBaseOperator | ||
| from airflow.utils.helpers import prune_dict | ||
| from airflow.sdk.utils.helpers import prune_dict |
Member
There was a problem hiding this comment.
Airflow Providers still support Airflow 2.0 so we can't just change to airflow.sdk
kaxil
requested changes
May 28, 2026
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Airflow Providers still support Airflow 2.0 so we can't just change to airflow.sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates deprecated import paths to their SDK equivalents across the codebase. Generated by airflow-ai, an AI-powered toolkit for Airflow maintenance.
Changes
312 import path corrections across 275 files:
airflow.utils.state→airflow.sdk.stateairflow.utils.helpers→airflow.sdk.utils.helpersairflow.exceptions.AirflowException→airflow.sdk.exceptions.AirflowExceptionairflow.utils.log→airflow.sdk.utils.logairflow.utils.timezone→pendulumVerification
airflow.utils.log.*) left intact — SDK equivalents don't exist yetNotes