Skip to content

[AIRFLOW-6205] The 'airflow db shell' works on mysql without port/passwd#6763

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6205-fail-airflow-db-shell-on-missing-port-password
Jan 1, 2020
Merged

[AIRFLOW-6205] The 'airflow db shell' works on mysql without port/passwd#6763
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:AIRFLOW-6205-fail-airflow-db-shell-on-missing-port-password

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Dec 9, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

The `airflow db shell' command now works also for mysql with no port/password

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk requested a review from mik-laj December 9, 2019 20:10
@potiuk
Copy link
Member Author

potiuk commented Dec 9, 2019

@mik-laj -> found it while cherry-picking to v1-10-test

@potiuk potiuk force-pushed the AIRFLOW-6205-fail-airflow-db-shell-on-missing-port-password branch from 0b4c978 to ff21c93 Compare December 9, 2019 23:03
@KKcorps
Copy link
Contributor

KKcorps commented Dec 16, 2019

Shouldn't we allow an empty value for all params? In the code, it's already allowed for Postgres.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
user = {url.username}
user = {url.username or ""}

Is Username optionally?

@mik-laj
Copy link
Member

mik-laj commented Dec 30, 2019

@potiuk Any progress on it?

@potiuk
Copy link
Member Author

potiuk commented Dec 30, 2019

Not really . Have another, more important stuff to work on. Care to take over?

@potiuk potiuk force-pushed the AIRFLOW-6205-fail-airflow-db-shell-on-missing-port-password branch from ff21c93 to e87fcf7 Compare December 31, 2019 23:50
@codecov-io
Copy link

Codecov Report

Merging #6763 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6763      +/-   ##
==========================================
- Coverage   84.85%   84.56%   -0.29%     
==========================================
  Files         679      679              
  Lines       38536    38536              
==========================================
- Hits        32698    32588     -110     
- Misses       5838     5948     +110
Impacted Files Coverage Δ
airflow/cli/commands/db_command.py 97.43% <ø> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.75% <0%> (-20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ddc42...e87fcf7. Read the comment docs.

@potiuk potiuk merged commit 6d2b4b7 into apache:master Jan 1, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments