Skip to content

Fix exceptions of positional session use in Edge provider#67661

Merged
jscheffl merged 2 commits into
apache:mainfrom
jscheffl:bugfix/clean-positional-session-use-in-edge
May 29, 2026
Merged

Fix exceptions of positional session use in Edge provider#67661
jscheffl merged 2 commits into
apache:mainfrom
jscheffl:bugfix/clean-positional-session-use-in-edge

Conversation

@jscheffl
Copy link
Copy Markdown
Contributor

Following PR #67150 this one cleans the exceptions in Edge provider


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added area:dev-tools area:providers backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch provider:edge Edge Executor / Worker (AIP-69) / edge3 labels May 28, 2026
Copy link
Copy Markdown
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Mypy is not happy with the queue_workload change.

We can't change the BaseExecutor.queue_workload directly, so the only way is to silence Mypy for queue_workload I think.

  providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: error: Signature of "queue_workload" incompatible with supertype "airflow.executors.base_executor.BaseExecutor"  [override]
          def queue_workload(
          ^~~~~~~~~~~~~~~~~~~
  providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: note:      Superclass:
  providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: note:          def queue_workload(self, workload: ExecuteTask | ExecuteCallback, session: Session) -> None
  providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: note:      Subclass:
  providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: note:          def queue_workload(self, workload: ExecuteTask | ExecuteCallback | RunTrigger, *, session: Session = ...) -> None
  Found 1 error in 1 file (checked 4503 source files)

@jscheffl jscheffl force-pushed the bugfix/clean-positional-session-use-in-edge branch from 25197f5 to 0e43104 Compare May 29, 2026 09:13
@jscheffl jscheffl merged commit a5f73bb into apache:main May 29, 2026
274 of 276 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Backport failed to create: v3-2-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test Commit Link

You can attempt to backport this manually by running:

cherry_picker a5f73bb v3-2-test

This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@jscheffl
Copy link
Copy Markdown
Contributor Author

Args, oh, should not be back-ported...

@jscheffl jscheffl removed the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label May 29, 2026
sunildataengineer pushed a commit to sunildataengineer/airflow that referenced this pull request May 30, 2026
* Fix exceptions of positional session use in Edge provider

* Revert interface-based limits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants