Fix exceptions of positional session use in Edge provider#67661
Conversation
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the fix! Mypy is not happy with the queue_workload change.
We can't change the BaseExecutor.queue_workload directly, so the only way is to silence Mypy for queue_workload I think.
providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: error: Signature of "queue_workload" incompatible with supertype "airflow.executors.base_executor.BaseExecutor" [override]
def queue_workload(
^~~~~~~~~~~~~~~~~~~
providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: note: Superclass:
providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: note: def queue_workload(self, workload: ExecuteTask | ExecuteCallback, session: Session) -> None
providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: note: Subclass:
providers/edge3/src/airflow/providers/edge3/executors/edge_executor.py:99: note: def queue_workload(self, workload: ExecuteTask | ExecuteCallback | RunTrigger, *, session: Session = ...) -> None
Found 1 error in 1 file (checked 4503 source files)
25197f5 to
0e43104
Compare
Backport failed to create: v3-2-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker a5f73bb v3-2-testThis should apply the commit to the v3-2-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
|
Args, oh, should not be back-ported... |
* Fix exceptions of positional session use in Edge provider * Revert interface-based limits
Following PR #67150 this one cleans the exceptions in Edge provider
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.