Skip to content

Remove stale type-ignore TODO in HTTP hook run_with_advanced_retry#67685

Open
ed-kyu wants to merge 1 commit into
apache:mainfrom
ed-kyu:fix/remove-stale-tenacity-type-ignore-todo
Open

Remove stale type-ignore TODO in HTTP hook run_with_advanced_retry#67685
ed-kyu wants to merge 1 commit into
apache:mainfrom
ed-kyu:fix/remove-stale-tenacity-type-ignore-todo

Conversation

@ed-kyu
Copy link
Copy Markdown
Contributor

@ed-kyu ed-kyu commented May 29, 2026

HttpHook.run_with_advanced_retry carried a TODO asking to remove a # type: ignore once tenacity#428 is resolved:

# TODO: remove ignore type when https://github.com/jd/tenacity/issues/428 is resolved
return self._retry_obj(self.run, *args, **kwargs)  # type: ignore

However, the # type: ignore itself was already removed in #53294 (Cleanup type ignores) — but that PR left the accompanying TODO comment behind. The comment now points at an ignore that no longer exists, so it is pure leftover noise. This PR removes the stale comment.
No functional or type-checking change: the # type: ignore has been absent since #53294 and mypy passes on main without it.


Was generative AI tooling used to co-author this PR?
  • Yes

Generated-by: Claude Code (Opus 4.8) following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

The TODO asked to drop a # type: ignore once tenacity issue apache#428 is
resolved, but the ignore itself was already removed in apache#53294 (Cleanup
type ignores) while the accompanying comment was left behind. The
comment now points at an ignore that no longer exists, so remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant