[v3-2-test] Speed up TaskGroup.topological_sort with int-indexed projected sweep (#67288)#67687
Merged
vatsrahul1001 merged 2 commits intoMay 29, 2026
Merged
Conversation
shahar1
requested review from
amoghrajesh,
ashb,
bolkedebruin and
kaxil
as code owners
shahar1
changed the title
These tests depend on TaskGroup.__getitem__ and NodeNotFound exception which don't exist in v3-2-test. Keep topological_sort shape correctness tests which are for the actual optimization. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
vatsrahul1001
approved these changes
May 29, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
May 29, 2026
…ected sweep (#67288) (#67687) * Speed up TaskGroup.topological_sort with int-indexed projected sweep (backport #67288) * Remove __getitem__ and NodeNotFound tests not available in v3-2-test These tests depend on TaskGroup.__getitem__ and NodeNotFound exception which don't exist in v3-2-test. Keep topological_sort shape correctness tests which are for the actual optimization. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #67288 to v3-2-test.
Was generative AI tooling used to co-author this PR?